Only forward valid URLs in open-urls-in-browser
This is unlikely to be exploited since the combinator only allows a single argument and is not parsed by any shell, but it seems like a good thing to ensure that only valid non-local URLs will be forwarded to $BROWSER.
This commit is contained in:
parent
977c3f2426
commit
e45e8a7ccb
3 changed files with 41 additions and 5 deletions
|
|
@ -15,9 +15,15 @@ in
|
|||
all URLs to the `$BROWSER` outside of the jail. This way the jailed
|
||||
program can launch your browser, even if it has a subset of the
|
||||
permissions your browser has.
|
||||
|
||||
Only URLs beginning with `http(s)://` will be forwarded.
|
||||
'';
|
||||
impl = compose [
|
||||
(jail-to-host-channel "browserchannel" ''"$BROWSER" "$1"'')
|
||||
(set-env "BROWSER" "browserchannel")
|
||||
(jail-to-host-channel "browserchannel" ''
|
||||
if [[ "$1" =~ ^https://|^http:// ]]; then
|
||||
"$BROWSER" "$1"
|
||||
fi
|
||||
'')
|
||||
];
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue